Split barchart module#1915
Open
lukavdplas wants to merge 19 commits into
Open
Conversation
remove trivial get method
Base automatically changed from
feature/explain-api-for-term-frequency
to
develop
January 19, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to untangle the barchart components somewhat, by separating the logic to fetch the data from the logic to render the graph/table. E.g.
TimelineComponentuses aTimelineDataobject that handles the data fetching.The logic in
BarchartData/HistogramData/TimelineDatais mostly lifted verbatim fromBarchartComponent/HistogramComponent/TimelineComponent, but I had to make some changes because the data object is not embedded in the component lifecycle in the same way.Note for review: the whole point of this is that these modules were a tangled mess (now slightly less so), so please don't spend too much time on this. Just scan the code to see if anything stands out.